[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1387839316.1635.8.camel@bwh-desktop.uk.level5networks.com>
Date: Mon, 23 Dec 2013 22:55:16 +0000
From: Ben Hutchings <bhutchings@...arflare.com>
To: Neil Horman <nhorman@...driver.com>
CC: <linux-sctp@...r.kernel.org>, Vlad Yasevich <vyasevich@...il.com>,
"David Miller" <davem@...emloft.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation
warnings
On Mon, 2013-12-23 at 08:29 -0500, Neil Horman wrote:
> The SCTP protocol has several deprecation warnings in its setsockopt path that
> can be triggered by unprivlidged users. Since these are not ratelimited, we can
> spam the logs quite easily here. Since these are all deprecation warnings, and
> that type of warning isn't uncommon in the rest of the kernel, lets make a
> common pr_warn_deprecated macro to produce somewhat generalized ratelimited
> deprecation warnings easily
[...]
No objection to these changes, but I think deprecation warnings should
log at least the command name and maybe also the pid of the caller.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists