linux-kernel - Re: [RFC v3] Add ff-memless-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387844508.22671.73.camel@joe-AO722>
Date:	Mon, 23 Dec 2013 16:21:48 -0800
From:	Joe Perches <joe@...ches.com>
To:	Michal Malý <madcatxster@...fuk.cz>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	elias.vds@...il.com
Subject: Re: [RFC  v3] Add ff-memless-next

On Mon, 2013-12-23 at 23:46 +0100, Michal Malý wrote:
> One case where uncombinable effects were mishandled was corrected. Rest of
> the changes are just coding style fixes.

trivia:

> diff --git a/drivers/input/ff-memless-next.c b/drivers/input/ff-memless-next.c
[]
> +static __always_inline s32 mlnx_calculate_x_force(const s32 level,
> +						  const u16 direction)

__always_inline is almost never warranted.
gcc generally does the right thing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/