linux-kernel - Re: [PATCH 2/4] block: blk-mq: make blk_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVOnWLUQPiPsHOyhhU66+M8B6v0cpCDgLp55S+anORzxAA@mail.gmail.com>
Date:	Tue, 24 Dec 2013 11:35:29 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jens Axboe <axboe@...nel.dk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] block: blk-mq: make blk_sync_queue support mq

Hello Christoph,


On Tue, Dec 24, 2013 at 12:25 AM, Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, Dec 24, 2013 at 12:18:57AM +0800, Ming Lei wrote:
>> This patch moves synchronization on mq->delay_work
>> from blk_mq_free_queue() to blk_sync_queue(), so that
>> blk_sync_queue can work on mq.
>
> Again, this is a LLD call, should have a separate blk_mq_sync_queue.
>

As I replied in previous mail, we have other LLD APIs which should be
called for MQ too, also making current APIs adapt to MQ can simplify
drivers.


Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/