linux-kernel - Re: [PATCH] slub: Fix calculation of cpu slabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLEiafGHcX6zy85NRXN7ydnVKNv2oZHNwffp9=hORxGJog@mail.gmail.com>
Date:	Sun, 29 Dec 2013 13:45:49 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Li Zefan <lizefan@...wei.com>, Christoph Lameter <cl@...ux.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH] slub: Fix calculation of cpu slabs

On Sat, Oct 5, 2013 at 10:48 AM, Wanpeng Li <liwanp@...ux.vnet.ibm.com> wrote:
> On Tue, Sep 10, 2013 at 11:43:37AM +0800, Li Zefan wrote:
>>  /sys/kernel/slab/:t-0000048 # cat cpu_slabs
>>  231 N0=16 N1=215
>>  /sys/kernel/slab/:t-0000048 # cat slabs
>>  145 N0=36 N1=109
>>
>>See, the number of slabs is smaller than that of cpu slabs.
>>
>>The bug was introduced by commit 49e2258586b423684f03c278149ab46d8f8b6700
>>("slub: per cpu cache for partial pages").
>>
>>We should use page->pages instead of page->pobjects when calculating
>>the number of cpu partial slabs. This also fixes the mapping of slabs
>>and nodes.
>>
>>As there's no variable storing the number of total/active objects in
>>cpu partial slabs, and we don't have user interfaces requiring those
>>statistics, I just add WARN_ON for those cases.
>>
>>Cc: <stable@...r.kernel.org> # 3.2+
>>Signed-off-by: Li Zefan <lizefan@...wei.com>
>
> Reviewed-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>

Applied and sorry for the slow response!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/