linux-kernel - Re: [PATCH] mm/slub: fix accumulate per cpu partial cache objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOJsxLFH5LGuF+vutPzB90EM9o376Jc99-rjY4qq18d1KQshhg@mail.gmail.com>
Date:	Sun, 29 Dec 2013 13:49:48 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Lameter <cl@...ux.com>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/slub: fix accumulate per cpu partial cache objects

On Sat, Dec 28, 2013 at 3:50 AM, Li Zefan <lizefan@...wei.com> wrote:
> On 2013/12/27 17:46, Wanpeng Li wrote:
>> SLUB per cpu partial cache is a list of slab caches to accelerate objects
>> allocation. However, current codes just accumulate the objects number of
>> the first slab cache of per cpu partial cache instead of traverse the whole
>> list.
>>
>> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
>> ---
>>  mm/slub.c |   32 +++++++++++++++++++++++---------
>>  1 files changed, 23 insertions(+), 9 deletions(-)
>>
>> diff --git a/mm/slub.c b/mm/slub.c
>> index 545a170..799bfdc 100644
>> --- a/mm/slub.c
>> +++ b/mm/slub.c
>> @@ -4280,7 +4280,7 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
>>                       struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab,
>>                                                              cpu);
>>                       int node;
>> -                     struct page *page;
>> +                     struct page *page, *p;
>>
>>                       page = ACCESS_ONCE(c->page);
>>                       if (!page)
>> @@ -4298,8 +4298,9 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
>>                       nodes[node] += x;
>>
>>                       page = ACCESS_ONCE(c->partial);
>> -                     if (page) {
>> -                             x = page->pobjects;
>> +                     while ((p = page)) {
>> +                             page = p->next;
>> +                             x = p->pobjects;
>>                               total += x;
>>                               nodes[node] += x;
>>                       }
>
> Can we apply this patch first? It was sent month ago, but Pekka was not responsive.

Applied. Wanpeng, care to resend your patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/