linux-kernel - Re: [PATCH v2] Bluetooth: Add hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201312301454.51096@pali>
Date:	Mon, 30 Dec 2013 14:54:47 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	Ивайло Димитров 
	<freemangordon@....bg>, "Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-bluetooth@...r.kernel.org development" 
	<linux-bluetooth@...r.kernel.org>,
	Ville Tervo <ville.tervo@...ia.com>,
	Sebastian Reichel <sre@...g0.de>
Subject: Re: [PATCH v2] Bluetooth: Add hci_h4p driver

On Monday 30 December 2013 13:13:50 Pavel Machek wrote:
> > > +
> > > +	if (not_valid) {
> > > +		dev_info(info->dev, "Valid bluetooth address not 
found,
> > > setting some random\n"); +		/* When address is not valid,
> > > use some random but Nokia MAC */ +		memcpy(info-
>bd_addr,
> > > nokia_oui, 3);
> > > +		get_random_bytes(info->bd_addr + 3, 3);
> > > +	}
> > 
> > This behavior is extremely dangerous. I would rather have
> > the device init or powering on the device fail instead of
> > making up a number that might clash with a real Nokia
> > device.
> 
> Perhaps people can donate bt addresses from their
> no-longer-functional bluetooth devices and we can select from
> such pool here? ;-).
> 
> Is there some experimental range we can allocate from?
> 

Wifi driver wl1251 (it is already in mainline) is doing same: 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireless/ti/wl1251/main.c#n1431

-- 
Pali Rohár
pali.rohar@...il.com


Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)