linux-kernel - Re: [PATCH v2] Bluetooth: Add hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201312301504.06745@pali>
Date:	Mon, 30 Dec 2013 15:04:06 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Sebastian Reichel <sre@...g0.de>
Cc:	Pavel Machek <pavel@....cz>, Marcel Holtmann <marcel@...tmann.org>,
	Ивайло Димитров 
	<freemangordon@....bg>, "Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-bluetooth@...r.kernel.org development" 
	<linux-bluetooth@...r.kernel.org>,
	Ville Tervo <ville.tervo@...ia.com>
Subject: Re: [PATCH v2] Bluetooth: Add hci_h4p driver

On Monday 30 December 2013 14:19:44 Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Dec 30, 2013 at 01:13:50PM +0100, Pavel Machek wrote:
> > [...]
> > 
> > Well, I can rename config option, but renaming the module
> > would break existing userland, no?
> 
> Why is the userland depending on the module name?
> 

grep told me that hci_h4p is used only in these (text) files:

* /etc/modprobe.d/maemo.conf
   alias platform:hci_h4p hci_h4p

So this is not needed if kernel driver contains correct 
MODULE_ALIAS macro.

* /etc/event.d/bluetooth-sysinfo
   echo ... > /sys/devices/platform/hci_h4p/bdaddr

This upstart script contains code for reading mac address from 
special sysinfod daemon and setting it to kernel driver. Once 
there will be uniform way for setting mac address that script can 
be changed.

So I think that renaming module will not break anything if kernel 
module will get (somehow) correct mac address (or if random one 
is acceptable).

-- 
Pali Rohár
pali.rohar@...il.com


Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)