lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Dec 2013 16:02:14 +0100 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Preeti Murthy <preeti.lkml@...il.com> CC: mingo@...hat.com, Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org Subject: Re: [PATCH 4/7] sched: remove unused parameter in nohz_balancer_kick function On 12/31/2013 12:17 PM, Preeti Murthy wrote: > Hi Daniel, > > This patch looks correct to me. > Reviewed-by: Preeti U Murthy <preeti@...ux.vnet.ibm.com Thanks Preeti for the review. -- Daniel > <mailto:preeti@...ux.vnet.ibm.com>> > > > On Mon, Dec 30, 2013 at 7:14 PM, Daniel Lezcano > <daniel.lezcano@...aro.org <mailto:daniel.lezcano@...aro.org>> wrote: > > The cpu parameter is no longer needed in nohz_balancer_kick, let's > remove > the parameter. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org > <mailto:daniel.lezcano@...aro.org>> > --- > kernel/sched/fair.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 1f7ed1a..c647c45 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -6517,7 +6517,7 @@ static inline int find_new_ilb(void) > * nohz_load_balancer CPU (if there is one) otherwise fallback to > any idle > * CPU (if there is one). > */ > -static void nohz_balancer_kick(int cpu) > +static void nohz_balancer_kick(void) > { > int ilb_cpu; > > @@ -6871,15 +6871,13 @@ static inline int on_null_domain(struct rq *rq) > */ > void trigger_load_balance(struct rq *rq) > { > - int cpu = rq->cpu; > - > /* Don't need to rebalance while attached to NULL domain */ > if (time_after_eq(jiffies, rq->next_balance) && > likely(!on_null_domain(rq))) > raise_softirq(SCHED_SOFTIRQ); > #ifdef CONFIG_NO_HZ_COMMON > if (nohz_kick_needed(rq) && likely(!on_null_domain(rq))) > - nohz_balancer_kick(cpu); > + nohz_balancer_kick(); > #endif > } > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > the body of a message to majordomo@...r.kernel.org > <mailto:majordomo@...r.kernel.org> > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists