linux-kernel - Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131231145111.GB3349@phenom.dumpdata.com>
Date:	Tue, 31 Dec 2013 09:51:11 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Yijing Wang <wangyijing@...wei.com>, JBeulich@...e.com
Cc:	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
	Hanjun Guo <guohanjun@...wei.com>
Subject: Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device

On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
> Use PCI standard marco dev_is_pci() instead of directly compare
> pci_bus_type to check whether it is pci device.

Jan, you OK with this?

> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> ---
>  drivers/xen/dbgp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
> index f3ccc80..8145a59 100644
> --- a/drivers/xen/dbgp.c
> +++ b/drivers/xen/dbgp.c
> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
>  	dbgp.op = op;
>  
>  #ifdef CONFIG_PCI
> -	if (ctrlr->bus == &pci_bus_type) {
> +	if (dev_is_pci(ctrlr)) {
>  		const struct pci_dev *pdev = to_pci_dev(ctrlr);
>  
>  		dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/