linux-kernel - Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <52CBFE27020000780011112F@nat28.tlf.novell.com>
Date:	Tue, 07 Jan 2014 12:16:23 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Yijing Wang" <wangyijing@...wei.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>
Cc:	"David Vrabel" <david.vrabel@...rix.com>,
	"Hanjun Guo" <guohanjun@...wei.com>,
	<xen-devel@...ts.xenproject.org>,
	"Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci
 device

>>> On 31.12.13 at 15:51, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:
> On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
>> Use PCI standard marco dev_is_pci() instead of directly compare
>> pci_bus_type to check whether it is pci device.
> 
> Jan, you OK with this?

Yes, sure - I simply wasn't aware of that wrapper.

Jan

>> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
>> ---
>>  drivers/xen/dbgp.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
>> index f3ccc80..8145a59 100644
>> --- a/drivers/xen/dbgp.c
>> +++ b/drivers/xen/dbgp.c
>> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
>>  	dbgp.op = op;
>>  
>>  #ifdef CONFIG_PCI
>> -	if (ctrlr->bus == &pci_bus_type) {
>> +	if (dev_is_pci(ctrlr)) {
>>  		const struct pci_dev *pdev = to_pci_dev(ctrlr);
>>  
>>  		dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
>> -- 
>> 1.7.1
>> 
>> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/