linux-kernel - Re: [PATCH] Staging: comedi: replace printk() calls with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140102121626.GB28413@mwanda>
Date:	Thu, 2 Jan 2014 15:16:26 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Chase Southwood <chase.southwood@...oo.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, abbotti@....co.uk
Subject: Re: [PATCH] Staging: comedi: replace printk() calls with dev_dbg()
 in pcmmio.c

On Sat, Dec 28, 2013 at 03:13:52AM -0600, Chase Southwood wrote:
> From: Chase Southwood <chase.southwood@...oo.com>

We get this from your email.  It's not needed unless you are forwarding
a patch from someone else.

> 
> This is a patch for pcmmio.c that changes several printk() calls to dev_dbg() or dev_err() to fix checkpatch.pl warnings.  Patched from 3.13-rc5.

Line wrap the description at 72 characters.

Don't put "Patched from 3.13-rc5." in the patch description because we
don't want it to be a part of the permanent change description.  Also
you should be doing these against linux-next anyway.

> 
> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> ---
>  drivers/staging/comedi/drivers/pcmmio.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
> index 14cee3a..8a567c9 100644
> --- a/drivers/staging/comedi/drivers/pcmmio.c
> +++ b/drivers/staging/comedi/drivers/pcmmio.c
> @@ -252,7 +252,8 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
>  
>  #ifdef DAMMIT_ITS_BROKEN
>  	/* DEBUG */
> -	printk(KERN_DEBUG "write mask: %08x  data: %08x\n", data[0], data[1]);
> +	dev_dbg(dev->class_dev, "write mask: %08x  data: %08x\n",
> +			data[0], data[1]);

Just delete everything to do with DAMMIT_ITS_BROKEN.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/