linux-kernel - Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 02 Jan 2014 11:53:43 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Tim Jester-Pfadt <t.jp@....de>, gregkh@...uxfoundation.org
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@....de>
> ---
>   drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
> index 10c9c65..69b408e 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_io.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_io.c
> @@ -205,7 +205,7 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
>   	_func_enter_;
>   	if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> -	     RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> +		RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
>   		      ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
>   		      adapter->bDriverStopped, adapter->bSurpriseRemoved));
>   	     return;
> @@ -239,7 +239,7 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>   	_func_enter_;
>
>   	if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> -	     RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> +		RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
>   		      ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
>   		      adapter->bDriverStopped, adapter->bSurpriseRemoved));
>   	     return;

Did you run checkpatch.pl on this patch? You fixed the indents on the RT_TRACE 
statements, but the alignment of the continuing statements is wrong. That part 
was correct before.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/