linux-kernel - Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jan 2014 17:00:42 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	jesse.brandeburg@...il.com,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	netdev <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	bjorn.helgaas@...com
Subject: Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

On Fri, Jan 3, 2014 at 4:56 PM, David Miller <davem@...emloft.net> wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> Date: Fri, 3 Jan 2014 15:15:57 -0700
>
>> However, I do raise my eyebrows a bit at drivers that poke around in
>> the PCIe capability.  I would prefer to have PCI core interfaces that
>> handle that instead.  But I haven't seen Jeff's changes yet.
>
> The changes just read the link status to interpret the speed at which
> the PCI-E link is running at.

Several drivers want to do that.  It'd be nice if somebody abstracted
that out somehow.  Jacob added pcie_get_minimum_link() which is
similar.  But maybe Jeff needs something more in this case.

In any case, it's not a blocker for this patch.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/