linux-kernel - RE: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B1AF3BC0D@HASMSX106.ger.corp.intel.com>
Date:	Sat, 4 Jan 2014 21:24:21 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	David Howells <dhowells@...hat.com>,
	Paul Bolle <pebolle@...cali.nl>
CC:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 7/7] Fix uninitialised variable warning in
 mei-amt-version.c



> -----Original Message-----
> From: David Howells [mailto:dhowells@...hat.com]
> Sent: Friday, January 03, 2014 18:34
> To: Paul Bolle
> Cc: dhowells@...hat.com; akpm@...ux-foundation.org; Greg Kroah-Hartman;
> Winkler, Tomas; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c
> 
> Paul Bolle <pebolle@...cali.nl> wrote:
> 
> > But it turns out that call of mei_deinit() isn't needed at all. All of
> > the members of mei_cl will be set later in mei_init() and none will be
> > used before they are set. So we can simply drop this call of
> > mei_deinit()."
> >
> > Is that analysis (still) correct?
> 
> It looks true as the code stands.  Can you send me your patch?

Yes, the analysis is correct,  need to fix the typo in the title and but otherwise ACK.

Thanks
Tomas



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/