linux-kernel - Re: [Patch v2 00/13] Introduce ACPI _DSM helper functions to simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 05 Jan 2014 22:58:59 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Lv Zheng <lv.zheng@...el.com>, Len Brown <lenb@...nel.org>,
	Tony Luck <tony.luck@...el.com>,
	Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>,
	Ashley Lai <ashley@...leylai.com>,
	Peter Huewe <peterhuewe@....de>,
	Rajiv Andrade <mail@...jiv.net>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Sirrix AG <tpmdd@...rix.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	David Airlie <airlied@...ux.ie>, Jiri Kosina <jkosina@...e.cz>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v2 00/13] Introduce ACPI _DSM helper functions to simplify code

On Thursday, December 19, 2013 08:38:09 PM Jiang Liu wrote:
> There are several drivers making use of ACPI _DSM method to detect
> and invoke device specific methods. Currently every driver has
> implemented its private version to support ACPI _DSM method.
> So this patch introduces three helper functions to support ACPI _DSM
> method, which will be used to replace open-coded versions.  It helps
> to simplify code and improve code readability.
> 
> It also includes some bugfixes for TPM/nouveau drivers.
> 
> It applies to the mainstream kernel on top of
> b0031f2 Merge tag 's2mps11-build' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
> 
> Due to lacking of hardware platform, I have only tested the ACPI _DSM
> helper functions and TPM related changes, but haven't tested changes to
> other drivers yet. So appreciate help to review and test these patches.
> 
> V1->V2
> 1) fix an issue in initializing acpi_object structure
> 
> Jiang Liu (13):
>   ACPI: introduce helper interfaces to support ACPI _DSM method
>   ACPI, extlog: replace open-coded _DSM specific code with helper
>     functions
>   PCI, pci-label: release allocated ACPI object on error recovery path
>   ACPI, PCI: replace open-coded _DSM specific code with helper
>     functions
>   PCI, pci-label: treat PCI label with index 0 as valid label
>   ACPI, TPM: fix memory leak when walking ACPI namespace
>   ACPI, TPM: matching node name instead of full path when searching for
>     TPM device
>   ACPI, TPM: replace open-coded _DSM specific code with helper
>     functions
>   ACPI, TPM: detecting PPI features by checking availability of _DSM
>     functions
>   ACPI, i2c-hid: replace open-coded _DSM specific code with helper
>     functions
>   ACPI, i915: replace open-coded _DSM specific code with helper
>     functions
>   nouveau: fix memory leak in ACPI _DSM related code
>   ACPI, nouveau: replace open-coded _DSM specific code with helper
>     functions
> 
>  drivers/acpi/acpi_extlog.c                     |   61 +---
>  drivers/acpi/utils.c                           |   98 ++++++
>  drivers/char/tpm/tpm_ppi.c                     |  406 +++++++++---------------
>  drivers/gpu/drm/i915/intel_acpi.c              |  144 ++-------
>  drivers/gpu/drm/nouveau/core/subdev/mxm/base.c |   48 +--
>  drivers/gpu/drm/nouveau/nouveau_acpi.c         |  134 +++-----
>  drivers/hid/i2c-hid/i2c-hid.c                  |   26 +-
>  drivers/pci/pci-label.c                        |  129 +++-----
>  include/acpi/acpi_bus.h                        |   26 ++
>  9 files changed, 406 insertions(+), 666 deletions(-)

I've queued up the entire series for 3.14, thanks a lot!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/