linux-kernel - Re: [PATCH V3 Resend] cpufreq: create cpufreq_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMgfFVoVJpOMXWtzVWj_F4pD-L9Osyv4u6=c8RUWOoLHFw@mail.gmail.com>
Date:	Thu, 9 Jan 2014 00:38:35 -0800
From:	Olof Johansson <olof@...om.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	Patch Tracking <patches@...aro.org>, cpufreq@...r.kernel.org,
	linux-pm@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 Resend] cpufreq: create cpufreq_generic_get() routine

Hi Viresh,

On Mon, Jan 6, 2014 at 5:54 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> CPUFreq drivers that use clock frameworks interface,i.e. clk_get_rate(), to get
> CPUs clk rate, has similar sort of code used for most of them.
>
> This patch adds a generic ->get() which will do the same thing for them. All
> those drivers are required to now is to set .get to cpufreq_generic_get() and
> set their clk pointer in policy->clk during ->init().
>
> Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>
> Acked-by: Shawn Guo <shawn.guo@...aro.org>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Acked-by: Shawn Guo <shawn.guo@...aro.org>
> Acked-by: Stephen Warren <swarren@...dia.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
> Rafael,
>
> V2->V3: As asked by you earlier, I have merged all 23 patches here as they had
> common log and were touching separate drivers. This is already acked by many
> people.  Please see if looks okay for 3.14.

This patch breaks a bunch of ARM boards. In particular, the following
defconfigs no longer build:

          assabet_defconfig
          badge4_defconfig
          cerfcube_defconfig
          collie_defconfig
          h3600_defconfig
          hackkit_defconfig
          jornada720_defconfig
          lart_defconfig
          neponset_defconfig
          pleb_defconfig
          shannon_defconfig
          simpad_defconfig

Error is:

drivers/built-in.o: In function `cpufreq_generic_get':
drivers/cpufreq/cpufreq.c:189: undefined reference to `clk_get_rate'

Seems like this needs to be guarded by HAVE_CLK?


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/