linux-kernel - Re: [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140109012411.GA7204@localhost.localdomain>
Date:	Thu, 9 Jan 2014 02:24:14 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	suravee.suthikulpanit@....com
Cc:	mingo@...nel.org, mingo@...hat.com, jacob.w.shin@...il.com,
	oleg@...hat.com, a.p.zijlstra@...llo.nl, acme@...stprotocols.net,
	hpa@...or.com, linux-kernel@...r.kernel.org, sherry.hurwitz@....com
Subject: Re: [PATCH 1/4] perf/x86/amd: AMD support for bp_len >
 HW_BREAKPOINT_LEN_8

On Wed, Dec 11, 2013 at 06:28:23AM -0600, suravee.suthikulpanit@....com wrote:
> @@ -295,11 +301,17 @@ static int arch_build_bp_info(struct perf_event *bp)
>  		break;
>  #endif
>  	default:
> -		return -EINVAL;
> +		if (!is_power_of_2(bp->attr.bp_len))
> +			return -EINVAL;
> +		if (!cpu_has_bpext)
> +			return -EOPNOTSUPP;
> +		info->mask = bp->attr.bp_len - 1;
> +		info->len = X86_BREAKPOINT_LEN_1;

I think I asked this before but I can't remember. So dr7 must have
length as LEN_1 for breakpoint extension?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/