lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jan 2014 01:35:24 +0000 From: Qi Wang 王起 (qiwang) <qiwang@...ron.com> To: "dedekind1@...il.com" <dedekind1@...il.com> CC: Adrian Hunter <adrian.hunter@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, Qi Wang 王起 (qiwang) <qiwang@...ron.com> Subject: RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted Hi Artem: Do you have any suggestion for my modification? Other code I think it is ok. Thanks -----Original Message----- From: Qi Wang 王起 (qiwang) Sent: Monday, January 06, 2014 1:11 PM To: 'dedekind1@...il.com' Cc: Adrian Hunter; linux-kernel@...r.kernel.org; linux-mtd@...ts.infradead.org Subject: RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted >Please, remember that I pushed your patch to a temporary branch, only >for you to be able to easily pick it. I do not send it upstream. >As I said, I need to you look at it and confirm that it is all-right. >And if it is not all-right, correct it. >This is because I modified it myself. >So waiting for your response on this. I checked the code you modified, compile, and run on our platform, it is ok. + ubi_err("cannot invalidate PEB %d, write returned %d write returned %d", + pnum, err, err); But I think above code print "write err" twice. so I suggest to change to below: + ubi_err("cannot invalidate PEB %d, write returned %d", pnum, err); I will send you the patch in another email convenient for you to apply patch. Thanks -- qiwang
Powered by blists - more mailing lists