linux-kernel - Re: Broken locking in leds-lp5523.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201401091524.53417@pali>
Date:	Thu, 9 Jan 2014 15:24:53 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Bryan Wu <cooloney@...il.com>
Cc:	Pavel Machek <pavel@....cz>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>, milo kim <milo.kim@...com>,
	Sebastian Reichel <sre@...ian.org>,
	Sebastian Reichel <sre@...g0.de>
Subject: Re: Broken locking in leds-lp5523.c

On Wednesday 08 January 2014 01:32:15 Bryan Wu wrote:
> On Tue, Jan 7, 2014 at 12:42 PM, Pavel Machek <pavel@....cz> 
wrote:
> > Hi!
> > 
> > There's some locking weirdness, and few missing comments in
> > lp5523 driver.
> > 
> > Now, this is untested patch from my reverse-engineering. I
> > hope I understood things right...
> > 
> > In particular, there's unbalanced unlock in
> > lp5523_update_program_memory, and
> > lp5523_update_program_memory needs to be protected by the
> > lock.
> > 
> > Comments? Does someone maintain this?
> 
> Actually the locking issue was fixed in my for-next branch,
> http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-led
> s.git/commit/?h=for-next&id=0d70bdb957cde2c25a4b3e4c93d0d33403
> 795be9
> 
> Thanks,
> -Bryan
> 

Now, with linus tree lp5523 driver does not work without above 
commit on Nokia N900 device. I think that commit should go to 
3.13 and stable... What do you think?

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)