| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140109.154232.65818281679170677.davem@davemloft.net> Date: Thu, 09 Jan 2014 15:42:32 -0500 (EST) From: David Miller <davem@...emloft.net> To: dan.j.williams@...el.com Cc: ncardwell@...gle.com, dmaengine@...r.kernel.org, yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org, jmorris@...ei.org, kuznet@....inr.ac.ru, kaber@...sh.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private From: Dan Williams <dan.j.williams@...el.com> Date: Thu, 9 Jan 2014 12:33:29 -0800 > On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell <ncardwell@...gle.com> wrote: >> On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams <dan.j.williams@...el.com> wrote: >>> net_dma was the only external user so this can become local to tcp.c >>> again. >> ... >>> -void tcp_cleanup_rbuf(struct sock *sk, int copied) >>> +static void cleanup_rbuf(struct sock *sk, int copied) >> >> I would vote to keep the tcp_ prefix. In the TCP code base that is the >> more common idiom, even for internal/static TCP functions, and >> personally I find it easier to read and work with in stack traces, >> etc. My 2 cents. >> > > Ok. It was cleanup_rbuf() in a former life, but one vote for leaving > the name as is is enough for me. You can make that two votes :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists