[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <52CFA22A.9060609@linux.intel.com>
Date: Fri, 10 Jan 2014 15:32:58 +0800
From: Jiang Liu <jiang.liu@...ux.intel.com>
To: "Li, ZhenHua" <zhen-hual@...com>, Joerg Roedel <joro@...tes.org>
CC: David Woodhouse <dwmw2@...radead.org>,
iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] x86/iommu: use bit structures for context_entry
I have noticed the same issue too. But after second check, seems
it's safe with current implementation, but obviously it's not
future safe.
On 2014/1/10 15:29, Li, ZhenHua wrote:
> I have not seen such a bug yet . but obviously a '=' should be used when
> you want to set a value.
>
> for example, if x != 0,
> x=10
> and
> x|=10
> will cause different result.
>
> ZhenHua
>
> On 01/07/2014 10:41 PM, Joerg Roedel wrote:
>> On Fri, Dec 20, 2013 at 04:45:01PM +0800, Li, Zhen-Hua wrote:
>>> There is a structure named context_entry used by intel iommu, and there
>>> are some bit operations on it. Use bit structure may make these
>>> operations
>>> easy.
>>> Also the function context_set_address_root may cause problem because
>>> it uses
>>> |= operation, not set the new value. And this patch can fix it.
>>
>> What is the problem you are trying to fix here? Is it an actual bug?
>>
>>
>> Joerg
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists