linux-kernel - Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389638711.5567.437.camel@haakon3.risingtidesystems.com>
Date:	Mon, 13 Jan 2014 10:45:11 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Sagi Grimberg <sagig@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

On Fri, 2014-01-10 at 16:09 -0500, Martin K. Petersen wrote:
> >>>>> "nab" == Nicholas A Bellinger <nab@...erainc.com> writes:
> 
> nab> This patch updates tcm_loop_driver_probe() to set protection
> nab> information using scsi_host_set_prot() and scsi_host_set_guard(),
> nab> which currently enabled all modes of DIF/DIX protection, minus DIF
> nab> TYPE0.
> 
> ITYM, DIX Type 0.

Yes.  Fixed up the commit message.

>  And ideally you'd have a way to choose between IP and
> T10 CRC for the guard type.
> 

Sure, this can be exposed at a tcm_loop configfs attribute that is
accessible after scsi_add_host() has been called, which I assume is OK
to do..

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/