linux-kernel - Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140114014003.GB4327@dhcp-16-126.nay.redhat.com>
Date:	Tue, 14 Jan 2014 09:40:03 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	Linux EFI <linux-efi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	Matt Fleming <matt@...sole-pimps.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"H. Peter Anvin" <hpa@...or.com>, Toshi Kani <toshi.kani@...com>
Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an
 arbitrary pagetable

On 01/13/14 at 06:48am, Arjan van de Ven wrote:
> On 1/13/2014 4:23 AM, Dave Young wrote:
> >>
> >>>How about do not limit to only if (pgd) case, instead do something
> >>>like below: set dump_to_dmesg as a module parameter
> >>
> >>X86_PTDUMP is not a module.
> >
> >Hmm, I just see the module macros in the code, since it's a bool Kconfig
> >I think the dump_pagetables.c need a cleanup,
> >remove the #include <linux/module.h> and below lines:
> >MODULE_LICENSE("GPL");
> >MODULE_AUTHOR("Arjan van de Ven <arjan@...ux.intel.com>");
> >MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables");
> 
> personally I consider it good form to always have this kind of information in .c files,
> regardless of the KConfig side of thing...

I agree it's good to add these infomation, but they can be added in comment.
IMHO it will be better in that way.

Thanks
Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/