linux-kernel - Re: perf probe: Build error with missing libraries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D495D1.5080505@hitachi.com>
Date:	Tue, 14 Jan 2014 10:41:37 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Jiri Olsa <jolsa@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: perf probe: Build error with missing libraries

(2014/01/14 3:14), Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 13, 2014 at 03:04:00PM -0300, Arnaldo Carvalho de Melo escreveu:
>> On a Ubuntu system just installed (13.10, x86_64), I'm installing the
>> devel libs one by one to check if there are problems with the automatic
>> disabling of features that requires libraries not installed.
>  
>> Stumbled at this:
>  
>> util/probe-event.c: At top level:
>> util/probe-event.c:193:12: error: ‘get_text_start_address’ defined but
>> not used [-Werror=unused-function]
> 
>> Investigating...
> 
> This patch below fixes it, applying.

Thank you for fixing it! It looks good for me.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>


> 
> Jiri, this is something else for the give-me-more-ponies list for
> tests/make: build it on freshly provisioned systems with multiple mixes
> of devel packages installed ;-)

I think we can change makefile to get some combinations of config options
when building perf tools.

Thank you,

> 
> - Arnaldo
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 86ed858..a4ee6b4 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -172,6 +172,7 @@ const char *kernel_get_module_path(const char *module)
>  	return (dso) ? dso->long_name : NULL;
>  }
>  
> +#ifdef HAVE_DWARF_SUPPORT
>  /* Copied from unwind.c */
>  static Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep,
>  				    GElf_Shdr *shp, const char *name)
> @@ -217,6 +218,7 @@ out:
>  	elf_end(elf);
>  	return ret;
>  }
> +#endif
>  
>  static int init_user_exec(void)
>  {
> @@ -750,7 +752,8 @@ static int kprobe_convert_to_perf_probe(struct probe_trace_point *tp,
>  
>  static int try_to_find_probe_trace_events(struct perf_probe_event *pev,
>  				struct probe_trace_event **tevs __maybe_unused,
> -				int max_tevs __maybe_unused, const char *target)
> +				int max_tevs __maybe_unused,
> +				const char *target __maybe_unused)
>  {
>  	if (perf_probe_event_need_dwarf(pev)) {
>  		pr_warning("Debuginfo-analysis is not supported.\n");
> 


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/