linux-kernel - Re: [tip:x86/urgent] x86, cpu, amd: Add workaround for family 16h, erratum 793

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D69291.8080003@linux.intel.com>
Date:	Wed, 15 Jan 2014 05:52:17 -0800
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	Borislav Petkov <bp@...e.de>, Ingo Molnar <mingo@...nel.org>
CC:	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	aravind.gopalakrishnan@....com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86, cpu, amd: Add workaround for family 16h,
 erratum 793

On 01/15/2014 05:36 AM, Borislav Petkov wrote:
>>
>> msr_read() would essentially map to rdmsr_safe(). Each method has a
>> return value that can be checked for failure.
> 
> I'm not sure we want to use the _safe() variants by default as it would
> generate the exception tables even in cases where they're clearly not
> needed.
> 

It would be particularly silly if what you end up with is in effect to
wrap msr_read/write() in a BUG_ON(), which is the effect of the current
(trapping) form.  There is something to be said for hard errors.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/