linux-kernel - Re: [alsa-devel] Problems with simple-card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vbxk7oqu.wl%kuninori.morimoto.gx@gmail.com>
Date:	Wed, 15 Jan 2014 16:30:00 -0800 (PST)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Jean-Francois Moine <moinejf@...e.fr>, alsa-devel@...a-project.org,
	Xiubo Li <Li.Xiubo@...escale.com>, lgirdwood@...il.com,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] Problems with simple-card

Hi

> > The main problem is about sysclk: when there is no clock in the DT,
> > you get the clock of the CPU or CODEC DAI. In my system, two clocks
> > are declared in the controller CPU DAI, but there is no .set_sysclk
> > pointer. So, snd_soc_dai_set_sysclk() returns -EINVAL and the card is
> > not created.
> 
> set_sysclk() should be returning -ENOTSUPP in this case as with
> set_fmt() and the generic code then ignoring that error.
> 
> > As I don't know why you need these fmt and sysclk, may you have a
> > look at these problems?
> 
> The overwhelming majority of combinations of devices need a format
> specifying (usually one will be imposed by the system design even if
> both devices could be master).

If my understanding is correct, this patch is the reason ?

71467e46414d3bab220de77d3d085be0c0aa03e1
(ASoC: simple-card: Add device's module clock selection)
    
It seems break non .set_sysclk drivers.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/