linux-kernel - RE: [PATCH] libahci: correct a misleading comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D9FFE20C522965449E182ACE73889AEB1A6A3344@IRSMSX105.ger.corp.intel.com>
Date:	Fri, 17 Jan 2014 12:10:46 +0000
From:	"Dorau, Lukasz" <lukasz.dorau@...el.com>
To:	Tejun Heo <tj@...nel.org>
CC:	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] libahci: correct a misleading comment

On Friday, January 17, 2014 1:00 PM Tejun Heo <tj@...nel.org> wrote:
> On Fri, Jan 17, 2014 at 12:43:20PM +0100, Lukasz Dorau wrote:
> > There is an error in a comment introduced by:
> > 	commit fa070ee6dc70bcc19737a2406d741b089b3149d5
> > 	libahci: fix turning on LEDs in ahci_start_port()
> >
> > Correct it.
> >
> > Signed-off-by: Lukasz Dorau <lukasz.dorau@...el.com>
> > ---
> >  drivers/ata/libahci.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> > index c482f8c..1f526e6 100644
> > --- a/drivers/ata/libahci.c
> > +++ b/drivers/ata/libahci.c
> > @@ -780,8 +780,8 @@ static void ahci_start_port(struct ata_port *ap)
> >  							       4);
> >  				/*
> >  				 * If busy, give a breather but do not
> > -				 * release EH ownership by using msleep()
> > -				 * instead of ata_msleep().  EM Transmit
> > +				 * release EH ownership by using ata_msleep()
> > +				 * instead of msleep().  EM Transmit
> 
> Can't the sentence be parsed to mean the same thing either way?  "(do
> not release EH ownership) by using msleep..." or "do not (release EH
> ownership by using ata_msleep)..."
> 
> With the context, I don't think which way to group things is
> ambiguous.  In fact, saying "instead of msleep()" is kinda confusing
> because using ata_msleep() should be the default.
> 

You are right. I give up ;-)

Thanks,
Lukasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/