linux-kernel - Re: [PATCH v6] Bluetooth: Add hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140117121451.GA15496@amd.pavel.ucw.cz>
Date:	Fri, 17 Jan 2014 13:14:51 +0100
From:	Pavel Machek <pavel@....cz>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Ивайло Димитров 
	<freemangordon@....bg>, "Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-bluetooth@...r.kernel.org development" 
	<linux-bluetooth@...r.kernel.org>,
	Ville Tervo <ville.tervo@...ia.com>,
	Sebastian Reichel <sre@...g0.de>
Subject: Re: [PATCH v6] Bluetooth: Add hci_h4p driver

Hi!

> > Add hci_h4p bluetooth driver to bluetooth-next. This device is used
> > for example on Nokia N900 cell phone.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > Signed-off-by: Pavel Machek <pavel@....cz>
> > Thanks-to: Sebastian Reichel <sre@...ian.org>
> > Thanks-to: Joe Perches <joe@...ches.com>
> > 
> > ---
> > 
> > Changes from v5: Comment fixes and some refactoring suggested by 
> > Joe Perches. Please apply.

> > --- /dev/null
> > +++ b/drivers/bluetooth/hci_h4p.h
> 
> can we please get the naming straight. File names do not start with hci_ anymore. We moved away from it since that term is too generic.
> 

Ok, this is easy.

> > +	struct timer_list lazy_release;
> 
> Timer? Not delayed work?

But these changes sound like bigger piece of refactoring, and more is
suggested below. Which is good, but will be tricky to develop/test on
bluetooth-next, as running Maemo is really needed for testing.

So... this will take longer than expected, and I believe it makes
sense to push it to staging, first. That will bring linux-n900 tree
closer to mainline, and preserve more of history.

Regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/