linux-kernel - Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201401171752.47393.arnd@arndb.de>
Date:	Fri, 17 Jan 2014 17:52:46 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Feng Kan <fkan@....com>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu

On Wednesday 15 January 2014, Feng Kan wrote:
> +static int __init xgene_reboot_init(void)
>  {
>         arm_pm_restart = xgene_restart;
>         return 0;
>  }
>  device_initcall(xgene_reboot_init);

This won't work on a generic kernel, since you unconditionally set the
pm_restart function to your own, which is broken for everything else.

Please keep the platform_driver to attach to the reboot device
as you had before. It might be good to turn this into a generic
"syscon-reset" driver that gets both the register number and
the contents to write from the device node.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/