linux-kernel - Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1389977983.940533034@f47.i.mail.ru>
Date:	Fri, 17 Jan 2014 20:59:43 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Feng Kan <fkan@....com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu

Пятница, 17 января 2014, 17:52 +01:00 от Arnd Bergmann <arnd@...db.de>:
> On Wednesday 15 January 2014, Feng Kan wrote:
> > +static int __init xgene_reboot_init(void)
> >  {
> >         arm_pm_restart = xgene_restart;
> >         return 0;
> >  }
> >  device_initcall(xgene_reboot_init);
> 
> This won't work on a generic kernel, since you unconditionally set the
> pm_restart function to your own, which is broken for everything else.
> 
> Please keep the platform_driver to attach to the reboot device
> as you had before. It might be good to turn this into a generic
> "syscon-reset" driver that gets both the register number and
> the contents to write from the device node.

I am not sure but think the new driver for SYSCON GPIOs can be
reused for such purpose:
http://www.spinics.net/lists/devicetree/msg18221.html

---