linux-kernel - Re: [PATCH] audit: Modify a set of system calls in audit class definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140117194224.GB7084@madcap2.tricolour.ca>
Date:	Fri, 17 Jan 2014 14:42:24 -0500
From:	Richard Guy Briggs <rgb@...hat.com>
To:	AKASHI Takahiro <takahiro.akashi@...aro.org>
Cc:	viro@...iv.linux.org.uk, eparis@...hat.com, arndb@...db.de,
	catalin.marinas@....com, will.deacon@....com,
	linux-arm-kernel@...ts.infradead.org,
	linaro-kernel@...ts.linaro.org, linux-kernel@...r.kernel.org,
	linux-audit@...hat.com, patches@...aro.org
Subject: Re: [PATCH] audit: Modify a set of system calls in audit class
 definitions

On 14/01/17, AKASHI Takahiro wrote:
> Each asm-generic/audit_xx.h defines a set of system calls for respective
> audit permssion class (read, write, change attribute or exec).
> This patch changes two entries:
> 
> 1) fchown in audit_change_attr.h
>   Make fchown included by its own because in asm-generic/unistd.h, for example,
>   fchown always exists while chown is optional. This change is necessary at
>   least for arm64.
> 
> 2) truncate64 in audit_write.h
>   Add missing truncate64/ftruncate64 as well as truncate/ftruncate
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>

Reviewed-by: Richard Guy Briggs <rgb@...hat.com>

> ---
>  include/asm-generic/audit_change_attr.h |    4 +++-
>  include/asm-generic/audit_write.h       |    6 ++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/asm-generic/audit_change_attr.h b/include/asm-generic/audit_change_attr.h
> index 89b73e5..a186553 100644
> --- a/include/asm-generic/audit_change_attr.h
> +++ b/include/asm-generic/audit_change_attr.h
> @@ -4,9 +4,11 @@ __NR_chmod,
>  __NR_fchmod,
>  #ifdef __NR_chown
>  __NR_chown,
> -__NR_fchown,
>  __NR_lchown,
>  #endif
> +#ifdef __NR_fchown
> +__NR_fchown,
> +#endif
>  __NR_setxattr,
>  __NR_lsetxattr,
>  __NR_fsetxattr,
> diff --git a/include/asm-generic/audit_write.h b/include/asm-generic/audit_write.h
> index e7020c5..274575d 100644
> --- a/include/asm-generic/audit_write.h
> +++ b/include/asm-generic/audit_write.h
> @@ -10,6 +10,12 @@ __NR_truncate,
>  #ifdef __NR_truncate64
>  __NR_truncate64,
>  #endif
> +#ifdef __NR_ftruncate
> +__NR_ftruncate,
> +#endif
> +#ifdef __NR_ftruncate64
> +__NR_ftruncate64,
> +#endif
>  #ifdef __NR_bind
>  __NR_bind,		/* bind can affect fs object only in one way... */
>  #endif
> -- 
> 1.7.9.5
> 

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/