linux-kernel - Re: [PATCH] pinctrl: capri: add dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D989C2.6030603@broadcom.com>
Date:	Fri, 17 Jan 2014 11:51:30 -0800
From:	Sherman Yin <syin@...adcom.com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Stephen Warren <swarren@...dia.com>,
	Christian Daudt <bcm@...thebug.org>
Subject: Re: [PATCH] pinctrl: capri: add dependency on OF

On 14-01-16 02:45 PM, Linus Walleij wrote:
> As this driver is using pinconf_generic_dt_node_to_map_pin() it
> needs to depend on OF so as not to cause build problems on
> archs that do not support OF.
>
> Cc: Sherman Yin <syin@...adcom.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>   drivers/pinctrl/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f1dda4d9de13..be361b7cd30f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,6 +106,7 @@ config PINCTRL_BCM2835
>
>   config PINCTRL_CAPRI
>   	bool "Broadcom Capri pinctrl driver"
> +	depends on OF
>   	select PINMUX
>   	select PINCONF
>   	select GENERIC_PINCONF
>

Thanks for the fix, Linus.  While we're visiting this config, should we 
add "depends on MACH_BCM_MOBILE" as well?

Thanks,
Sherman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/