linux-kernel - Re: [PATCH v4 8/8] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201401172106.55668.arnd@arndb.de>
Date:	Fri, 17 Jan 2014 21:06:55 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Marc Carino <marc.ceeeee@...il.com>
Cc:	Christian Daudt <bcm@...thebug.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Matt Porter <matt.porter@...aro.org>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 8/8] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445

On Friday 17 January 2014, Marc Carino wrote:
> +       serial@...06b00 {
> +               compatible = "ns16550a";
> +               reg = <0x00 0xf0406b00 0x00 0x20>;
> +               reg-shift = <2>;
> +               reg-io-width = <4>;
> +               interrupts = <0 75 0x4>;
> +               clock-frequency = <0x4d3f640>;
> +       };
> +
> +       rdb {
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               compatible = "simple-bus";
> +               ranges = <0 0x00 0xf0000000 0x1000000>;
> +
> +               sun_top_ctrl: syscon@...000 {
> +                       compatible = "brcm,bcm7445-sun-top-ctrl",
> +                                    "syscon";
> +                       reg = <0x404000 0x51c>;
> +               };
> +

Yes, this looks better, but as a minor comment, the serial device above
should really be part of the rdb bus now, since that encompasses the
0xf0000000 device range.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/