linux-kernel - Re: [PATCH 3/5] mfd: tc3589x: reform device tree probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140121171527.GD27111@lee--X1>
Date:	Tue, 21 Jan 2014 17:15:27 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] mfd: tc3589x: reform device tree probing

> > This changes the following mechanisms in the TC3589x device tree
> > probing path:
> >
> > - Use the .of_match_table in struct device_driver to match the
> >   device in the device tree.
> > - Add matches for the proper compatible strings "toshiba,..."
> >   and all sub-variants, just as is done for the .id matches.
> > - Move over all the allocation of platform data etc to the
> >   tc3589x_of_probe() function and follow the pattern of passing
> >   a platform data pointer back, or an error pointer on error,
> >   as found in the STMPE driver.
> > - Match the new (proper) compatible strings for the GPIO and
> >   keypad MFD cells.
> > - Use of_device_is_compatible() rather than just !strcmp()
> >   to discover which cells to instantiate.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Waiting for this patch to go in as well... I can resend the
> entire set of it helps.

If you do so, I'll endeavour to get them sent during -rc1.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/