linux-kernel - Re: [PATCH 0/5] EFI memmap and other fixes, v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140123090654.GA17297@console-pimps.org>
Date:	Thu, 23 Jan 2014 09:06:54 +0000
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Linux EFI <linux-efi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"H. Peter Anvin" <hpa@...or.com>, Toshi Kani <toshi.kani@...com>
Subject: Re: [PATCH 0/5] EFI memmap and other fixes, v3

On Sat, 18 Jan, at 12:48:13PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> Hi all,
> 
> this is the latest incarnation which should hopefully work just fine. It
> tpasses esting at least on all our boxes so we have *some* coverage.
> 
> It took us a long time to debug the unmapping path and realize how
> exactly we're doing the PGD sharing between the kernel and the EFI page
> table. I've commented on this verbosely in 4/5 for future reference
> because this stuff is not trivial.
> 
> We definitely should have this in mind when we do more changes on how we
> handle the EFI page table and what we do with it, maybe even decouple it
> completely from the kernel one. I dunno - it is all future stuff to pay
> attention to.
> 
> Anyway, if anyone with an EFI box wants to give it a run, feel free to
> do so.
> 
> As always, all comments and suggestions are appreciated.

Thanks Borislav. I picked these up and applied them to my 'next' branch.

You'll notice that I haven't stuck them in my 'urgent' branch, so these
won't be sent to Linus before v3.15 despite the fact that they're bug
fixes. I think Toshi's box is special enough that most people shouldn't
hit this issue, and since these patches involve rewriting the way we do
SetVirtualAddressMap() I'm happy for people to hammer on the stuff that
did make it into the merge window without this added complication.

Having said that, if people think it's worth the effort I don't mind
setting up a new branch containing this series that can be sent to Linus
much sooner.

Thoughts?

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/