linux-kernel - Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1401231502010.891-100000@iolanthe.rowland.org>
Date:	Thu, 23 Jan 2014 15:06:02 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Valentina Manea <valentina.manea.m@...il.com>
cc:	Greg KH <gregkh@...uxfoundation.org>,
	Anthony Foiani <anthony.foiani@...il.com>,
	<devel@...verdev.osuosl.org>, <navinp@...c.in>,
	<linux-usb@...r.kernel.org>, <ly80toro@....cs.fau.de>,
	<josh@...htriplett.org>, <linux-kernel@...r.kernel.org>,
	"Linux Kernel Community @ ROSEdu" <firefly@...ts.rosedu.org>,
	<tulinizer@...il.com>, <yacine.belkadi.1@...il.com>,
	<ke42caxa@....cs.fau.de>
Subject: Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

On Thu, 23 Jan 2014, Valentina Manea wrote:

> 1. The usbip_status file is no longer created for interface 0, but for
> the whole device (such as
> /sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/usbip_status).
> 2. Per interface information, such as interface class or protocol, is
> no longer sent/received. Only device specific information is
> transmitted.
> 3. Since the driver was moved one level below in the USB architecture,
> there is no need to bind/unbind each interface, just the device as a
> whole.

If you don't bind the interfaces, they will naturally bind to their 
normal drivers on the host.  You probably don't want that to happen.  
(Although, at the moment, I don't see how you can prevent it.)

Also, in your patch, stub_probe() calls usb_choose_configuration().  
Shouldn't that be done by the client, since the client now has access 
to the entire device?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/