linux-kernel - Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Jan 2014 23:10:09 +0200
From:	Valentina Manea <valentina.manea.m@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Anthony Foiani <anthony.foiani@...il.com>,
	devel@...verdev.osuosl.org, navinp@...c.in,
	linux-usb@...r.kernel.org, ly80toro@....cs.fau.de,
	josh@...htriplett.org, linux-kernel@...r.kernel.org,
	"Linux Kernel Community @ ROSEdu" <firefly@...ts.rosedu.org>,
	Tülin İzer <tulinizer@...il.com>,
	yacine.belkadi.1@...il.com, ke42caxa@....cs.fau.de
Subject: Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

> If you don't bind the interfaces, they will naturally bind to their
> normal drivers on the host.  You probably don't want that to happen.
> (Although, at the moment, I don't see how you can prevent it.)
>

That's true but, the way I see USB/IP general use case, the drivers
from the host the device is physically attached to won't even be
actually used, since the host doesn't use the device. However, I can't
think of a way to enforce this.

> Also, in your patch, stub_probe() calls usb_choose_configuration().
> Shouldn't that be done by the client, since the client now has access
> to the entire device?

I think the normal user just wants things *to work*. Surely, for
advanced user an option for choosing the configuration could be added
but I, personally, don't see it as a necessity at this point.

Thanks,
Valentina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/