linux-kernel - Re: [PATCH] cpusets: Allocate heap only when required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1401240300570.24372@chino.kir.corp.google.com>
Date:	Fri, 24 Jan 2014 03:15:11 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Tejun Heo <tj@...nel.org>
cc:	Li Zefan <lizefan@...wei.com>,
	Viresh Kumar <viresh.kumar@...aro.org>, mingo@...nel.org,
	peterz@...radead.org, linaro-kernel@...ts.linaro.org,
	patches@...aro.org, linux-kernel@...r.kernel.org,
	Cgroups <cgroups@...r.kernel.org>
Subject: Re: [PATCH] cpusets: Allocate heap only when required

On Fri, 24 Jan 2014, Tejun Heo wrote:

> > Nobody is depending on shit, the patch is removing a completely pointless 
> > memory allocation in braindead cpuset code.  What you think is "harmful" 
> > or "more harmful" is irrelevant, but nobody said anything about depending 
> > on that behavior to do anything.
> 
> Weren't you talking something of that effect in memcg?  Or was it
> Michal?

In a completely different thread, I was talking about how we'd like to 
provide a small amount of memory in oom conditions so that you could do 
things like read the cgroup tasks file, but you'd also need the same thing 
to do just about anything, ls, ps, read /proc/pid/status, etc with true 
slab accounting.  Forget about this unnecessary heap allocation, you 
couldn't even do the open() in an oom condition.

That functionality would be provided by the memory reserves set aside for 
userspace oom handlers as part of that feature, cgroups wouldn't be 
different than anything else in that regard, it's a memcg and page 
allocator issue only.

> At any rate, I think you're missing the point why Li replied
> that it's harmless.  He, I think, meant that it doesn't make any
> semantical difference to userland, so your reply saying that it's not
> harmless listing the failure mode under memory pressure seemed
> misleading, so I thought clarification was necessary.

I would consider any memory allocation that is completely unnecessary to 
cause anything to fail unnecessarily to be harmful, nothing specific here 
about update_flag(), cpusets, or cgroups.  Saying something is "harmless" 
makes it sound like there's no downside to doing it, and that's obviously 
not the case.

We agree and I think the only outcome of this discussion is that we both 
wasted time :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/