linux-kernel - Re: [PATCH] pinctrl: Avoid kasprintf/kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140130205000.GX22609@sirena.org.uk>
Date:	Thu, 30 Jan 2014 20:50:00 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] pinctrl: Avoid kasprintf/kfree

On Thu, Jan 30, 2014 at 12:37:36PM -0800, Joe Perches wrote:

> +	char propname[9 + sizeof(int) * 2 + 4] = "pinctrl-";

I'm not sure this is a triumph of legibility - there's several magic
numbers there and it's not blindlingly obvious where the caclculation
came from.  Is this really a hot enough code path to benefit from an
optimisation like this?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)