| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1391163792-21819-3-git-send-email-maxime.ripard@free-electrons.com> Date: Fri, 31 Jan 2014 11:23:11 +0100 From: Maxime Ripard <maxime.ripard@...e-electrons.com> To: Mark Brown <broonie@...nel.org> Cc: linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Maxime Ripard <maxime.ripard@...e-electrons.com> Subject: [PATCH 2/3] spi: core: Update the devm_spi_register_master documentation If the devm_spi_register_master function is used together with the spi_alloc_master as advertised in the documentation, it will either lead to a memory leak if spi_put_master is removed, or we will try to access an already freed memory area during the unregistration function. Advertise that you want to use the devm_spi_alloc_master function in such case. Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com> --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index eb728ec..dc577b7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1444,7 +1444,7 @@ static void devm_spi_unregister(struct device *dev, void *res) /** * dev_spi_register_master - register managed SPI master controller * @dev: device managing SPI master - * @master: initialized master, originally from spi_alloc_master() + * @master: initialized master, originally from devm_spi_alloc_master() * Context: can sleep * * Register a SPI device as with spi_register_master() which will -- 1.8.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists