linux-kernel - Re: [PATCH] irq: fix a Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1401310223460.7183@chino.kir.corp.google.com>
Date:	Fri, 31 Jan 2014 02:27:04 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	nitin.a.kamble@...el.com
cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: fix a Kconfig dependency

On Thu, 30 Jan 2014, nitin.a.kamble@...el.com wrote:

> From: Nitin A Kamble <nitin.a.kamble@...el.com>
> 
> The generic_chip.c uses interfaces from irq_domain.c which is controlled by
> the IRQ_DOMAIN config option.
> 
> Add a select statement in the Kconfig to reflect this requirement.
> 
> Without this fix, the generic_chip.c compilation fails like this:
> 
> linux/kernel/irq/generic-chip.c:400:11:
>   error: 'irq_domain_xlate_onetwocell' undeclared here (not in a function)
> 

You're not specifying which config option you have enabled that selects 
CONFIG_GENERIC_IRQ_CHIP and does not select CONFIG_IRQ_DOMAIN, but it does 
look like there is a dependency here.

So, if this dependency is reasonable, it begs the question of why we have 
CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c 
depend on CONFIG_IRQ_DOMAIN.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/