linux-kernel - Re: [RFC PATCH] net: core: move core networking work to power efficient workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52EAF2E5.8090403@meshcoding.com>
Date:	Fri, 31 Jan 2014 01:48:37 +0100
From:	Antonio Quartulli <antonio@...hcoding.com>
To:	Zoran Markovic <zoran.markovic@...aro.org>,
	linux-kernel@...r.kernel.org
CC:	netdev@...r.kernel.org, Shaibal Dutta <shaibal.dutta@...adcom.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jiri Pirko <jiri@...nulli.us>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Julian Anastasov <ja@....bg>, Flavio Leitner <fbl@...hat.com>,
	Neil Horman <nhorman@...driver.com>,
	Patrick McHardy <kaber@...sh.net>,
	John Fastabend <john.r.fastabend@...el.com>,
	Amerigo Wang <amwang@...hat.com>,
	Joe Perches <joe@...ches.com>,
	Jason Wang <jasowang@...hat.com>,
	Simon Horman <horms@...ge.net.au>,
	Nikolay Aleksandrov <nikolay@...hat.com>
Subject: Re: [RFC PATCH] net: core: move core networking work to power efficient
 workqueue

On 31/01/14 01:33, Zoran Markovic wrote:
> From: Shaibal Dutta <shaibal.dutta@...adcom.com>

[...]

> -		schedule_delayed_work(&linkwatch_work, delay);
> +		queue_delayed_work(system_power_efficient_wq,
> +			&linkwatch_work, delay);

before talking about technical details, here and in other spots of this
patch the alignment is wrong. I think checkpatch should have said
something about it. The first parameter on the new line should be
aligned up to the column after the opening parenthesis.

Regards,

>  }
>  
>  
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index c03f3de..2c8f839 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -101,7 +101,8 @@ static void queue_process(struct work_struct *work)
>  			__netif_tx_unlock(txq);
>  			local_irq_restore(flags);
>  
> -			schedule_delayed_work(&npinfo->tx_work, HZ/10);
> +			queue_delayed_work(system_power_efficient_wq,
> +				&npinfo->tx_work, HZ/10);
>  			return;
>  		}
>  		__netif_tx_unlock(txq);
> @@ -423,7 +424,8 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
>  
>  	if (status != NETDEV_TX_OK) {
>  		skb_queue_tail(&npinfo->txq, skb);
> -		schedule_delayed_work(&npinfo->tx_work,0);
> +		queue_delayed_work(system_power_efficient_wq,
> +			&npinfo->tx_work, 0);
>  	}
>  }
>  EXPORT_SYMBOL(netpoll_send_skb_on_dev);
> 


-- 
Antonio Quartulli


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)