linux-kernel - Re: [PATCH] irq: fix a Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1401311241080.27318@chino.kir.corp.google.com>
Date:	Fri, 31 Jan 2014 12:45:59 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	"Kamble, Nitin A" <nitin.a.kamble@...el.com>
cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: fix a Kconfig dependency

On Fri, 31 Jan 2014, Kamble, Nitin A wrote:

> > So, if this dependency is reasonable, it begs the question of why we have
> > CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c
> > depend on CONFIG_IRQ_DOMAIN.
> Looking at the code there are cases where IRQ_DOMAIN functionality is used
> without using the GENERIC_IRQ_CHIP. So making generic-chip.c depend
> on CONFIG_IRQ_DOMAIN in the makefile will reduce the flexibility of using
> these config options separately.
> 

Acked-by: David Rientjes <rientjes@...gle.com>

Although the changelog should be updated since I get a couple problems 
when trying to enable CONFIG_GENERIC_IRQ_CHIP without CONFIG_IRQ_DOMAIN on 
Linus's latest tree:

kernel/irq/generic-chip.c:400:11: error: ‘irq_domain_xlate_onetwocell’ undeclared here (not in a function)
kernel/irq/generic-chip.c: In function ‘irq_gc_get_irq_data’:
kernel/irq/generic-chip.c:522:2: error: implicit declaration of function ‘irq_find_mapping’ [-Werror=implicit-function-declaration]