linux-kernel - Re: [PATCH] timerfd: show procfs fdinfo helper, and now accepts write()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1402042033310.24986@ionos.tec.linutronix.de>
Date:	Tue, 4 Feb 2014 21:00:02 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Shawn Landden <shawn@...rchofgit.com>
cc:	criu@...nvz.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, avagin@...il.com,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] timerfd: show procfs fdinfo helper, and now accepts
 write()

On Mon, 3 Feb 2014, Shawn Landden wrote:

> | pos:	0
> | flags:	02004002
> | clockid:	0
> | ticks:        6

This changelog is completely useless. It neither explains WHY we need
to expose that fdinfo nor WHAT the write function is supposed to do.

Aside of that the code lacks any comment and there is no documentation
for the new user ABI.

> Signed-off-by: Shawn Landden <shawn@...rchofgit.com>

I'm not going to find and read the bible of the churchofgit to figure
out what this is all about.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/