linux-kernel - Re: [PATCH] qla2xxx: Re-sync module parameter descriptions with the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.WNT.2.00.1402041508290.5360@N5102REMCQXM4BS.qlogic.org>
Date:	Tue, 4 Feb 2014 15:09:22 -0500
From:	Chad Dupuis <chad.dupuis@...gic.com>
To:	"Steven J. Magnani" <steve.magnani@...idescorp.com>
CC:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Steven J. Magnani" <steve@...idescorp.com>
Subject: Re: [PATCH] qla2xxx: Re-sync module parameter descriptions with the
 code



On Tue, 4 Feb 2014, Steven J. Magnani wrote:

> Fix module parameter descriptions mentioning default values that no longer
> match the code.
>
> Signed-off-by: Steven J. Magnani <steve@...idescorp.com>
> ---
> diff -uprN linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> --- linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c	2014-02-02 18:42:13.000000000 -0600
> +++ b/drivers/scsi/qla2xxx/qla_os.c	2014-02-04 12:41:45.133576764 -0600
> @@ -120,15 +120,17 @@ MODULE_PARM_DESC(ql2xmaxqdepth,
> int ql2xenabledif = 2;
> module_param(ql2xenabledif, int, S_IRUGO);
> MODULE_PARM_DESC(ql2xenabledif,
> -		" Enable T10-CRC-DIF "
> -		" Default is 0 - No DIF Support. 1 - Enable it"
> -		", 2 - Enable DIF for all types, except Type 0.");
> +		" Enable T10-CRC-DIF:\n"
> +		" Default is 2.\n"
> +		"  0 -- No DIF Support\n"
> +		"  1 -- Enable DIF for all types\n"
> +		"  2 -- Enable DIF for all types, except Type 0.\n");
>
> int ql2xenablehba_err_chk = 2;
> module_param(ql2xenablehba_err_chk, int, S_IRUGO|S_IWUSR);
> MODULE_PARM_DESC(ql2xenablehba_err_chk,
> 		" Enable T10-CRC-DIF Error isolation by HBA:\n"
> -		" Default is 1.\n"
> +		" Default is 2.\n"
> 		"  0 -- Error isolation disabled\n"
> 		"  1 -- Error isolation enabled only for DIX Type 0\n"
> 		"  2 -- Error isolation enabled for all Types\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Looks good. Thanks.

Acked-by: Chad Dupuis <chad.dupuis@...gic.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/