linux-kernel - Re: [PATCH 08/18] mfd: max14577: Rename state container to maxim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1391597296.3726.13.camel@AMDC1943>
Date:	Wed, 05 Feb 2014 11:48:16 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Mark Brown <broonie@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH 08/18] mfd: max14577: Rename state container to maxim_core

+Cc: Chanwoo, Mark and Dmitry for ACK-s on their subsystems.

Krzysztof Kozlowski

On Mon, 2014-02-03 at 09:42 +0000, Lee Jones wrote:
> > This patch continues the preparation for adding support for max77836
> > device to existing max14577 driver.
> > 
> > The patch renames the struct "max14577" state container to "maxim_core".
> > This is only a rename-like patch, new code is not added.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> > ---
> >  drivers/extcon/extcon-max14577.c     |   22 +++++------
> >  drivers/mfd/max14577.c               |   68 +++++++++++++++++-----------------
> >  drivers/power/max14577_charger.c     |   16 ++++----
> >  drivers/regulator/max14577.c         |    6 +--
> >  include/linux/mfd/max14577-private.h |    5 ++-
> >  5 files changed, 60 insertions(+), 57 deletions(-)
> 
> Need some more maintainer Acks here.
> 
> > -struct max14577 {
> > +/*
> > + * State container for max14577-like drivers.
> > + */
> 
> I don't think this comment is required.
> 
> Besides that, the code looks fine:
>   Acked-by: Lee Jones <lee.jones@...aro.org>
> 
> > +struct maxim_core {
> >  	struct device *dev;
> >  	struct i2c_client *i2c; /* Slave addr = 0x4A */
> >  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/