linux-kernel - Re: [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140209130456.GA30767@leaf>
Date:	Sun, 9 Feb 2014 05:04:56 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Christine Caulfield <ccaulfie@...hat.com>,
	David Teigland <teigland@...hat.com>, cluster-devel@...hat.com
Subject: Re: [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c

On Sun, Feb 09, 2014 at 06:19:17PM +0530, Rashika Kheria wrote:
> Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it
> contains function prototypes of some functions defined in fs/dlm/ast.c.
> 
> This also eliminates the following warning in fs/dlm/ast:
> fs/dlm/ast.c:52:5: warning: no previous prototype for ‘dlm_add_lkb_callback’ [-Wmissing-prototypes]
> fs/dlm/ast.c:113:5: warning: no previous prototype for ‘dlm_rem_lkb_callback’ [-Wmissing-prototypes]
> fs/dlm/ast.c:174:6: warning: no previous prototype for ‘dlm_add_cb’ [-Wmissing-prototypes]
> fs/dlm/ast.c:212:6: warning: no previous prototype for ‘dlm_callback_work’ [-Wmissing-prototypes]
> fs/dlm/ast.c:267:5: warning: no previous prototype for ‘dlm_callback_start’ [-Wmissing-prototypes]
> fs/dlm/ast.c:278:6: warning: no previous prototype for ‘dlm_callback_stop’ [-Wmissing-prototypes]
> fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’ [-Wmissing-prototypes]
> fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  fs/dlm/ast.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c
> index 0e90f0c..42794c0 100644
> --- a/fs/dlm/ast.c
> +++ b/fs/dlm/ast.c
> @@ -14,6 +14,7 @@
>  #include "dlm_internal.h"
>  #include "lock.h"
>  #include "user.h"
> +#include "ast.h"
>  
>  static uint64_t dlm_cb_seq;
>  static DEFINE_SPINLOCK(dlm_cb_seq_spin);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/