linux-kernel - Re: [PATCH 03/21] fs: Mark function as static in fs/bio-integrity.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140209130517.GB30767@leaf>
Date:	Sun, 9 Feb 2014 05:05:18 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Kent Overstreet <kmo@...erainc.com>,
	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 03/21] fs: Mark function as static in fs/bio-integrity.c

On Sun, Feb 09, 2014 at 06:22:53PM +0530, Rashika Kheria wrote:
> Mark functions as static in bio-integrity.c because it is not used
> outside this file.
> 
> This eliminates the following warnings in bio-integrity.c:
> fs/bio-integrity.c:224:5: warning: no previous prototype for ‘bio_integrity_tag’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  fs/bio-integrity.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 0bad24d..51d15ae 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> @@ -226,7 +226,8 @@ unsigned int bio_integrity_tag_size(struct bio *bio)
>  }
>  EXPORT_SYMBOL(bio_integrity_tag_size);
>  
> -int bio_integrity_tag(struct bio *bio, void *tag_buf, unsigned int len, int set)
> +static int bio_integrity_tag(struct bio *bio, void *tag_buf, unsigned int len,
> +			     int set)
>  {
>  	struct bio_integrity_payload *bip = bio->bi_integrity;
>  	struct blk_integrity *bi = bdev_get_integrity(bio->bi_bdev);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/