linux-kernel - Re: [PATCH 04/21] fs: Add prototype declaration to appropriate header file include/linux/bio.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140209130553.GC30767@leaf>
Date:	Sun, 9 Feb 2014 05:05:53 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Kent Overstreet <kmo@...erainc.com>,
	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 04/21] fs: Add prototype declaration to appropriate
 header file include/linux/bio.h

On Sun, Feb 09, 2014 at 06:30:39PM +0530, Rashika Kheria wrote:
> Add prototype declaration to header file include/linux/bio.h because it
> is used by more than one file.
> 
> This eliminates the following warning in bio-integrity.c:
> fs/bio-integrity.c:214:14: warning: no previous prototype for ‘bio_integrity_tag_size’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

> Some of the API functions like bio_integrity_tag_size appears to be
> entirely unused. Such occurences should be pruned because they haven't
> been used in any driver.
> 
>  include/linux/bio.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 7065452..d6791bb 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -332,6 +332,7 @@ extern struct bio *bio_clone_fast(struct bio *, gfp_t, struct bio_set *);
>  extern struct bio *bio_clone_bioset(struct bio *, gfp_t, struct bio_set *bs);
>  
>  extern struct bio_set *fs_bio_set;
> +unsigned int bio_integrity_tag_size(struct bio *bio);
>  
>  static inline struct bio *bio_alloc(gfp_t gfp_mask, unsigned int nr_iovecs)
>  {
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/