linux-kernel - Re: [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGu+2S6iGfisgBc=S9Lq38f-Qc=KU67Zb7tzWArXCiy0fw@mail.gmail.com>
Date:	Sun, 9 Feb 2014 08:37:22 -0500
From:	Rob Clark <robdclark@...il.com>
To:	sagar.a.kamble@...el.com
Cc:	Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
	vijay.a.purushothaman@...el.com, David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	"Valkeinen, Tomi" <tomi.valkeinen@...com>,
	"airlied@...hat.com" <airlied@...hat.com>,
	Archit Taneja <archit@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	joe@...ches.com,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>
Subject: Re: [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create_bitmask()

On Fri, Feb 7, 2014 at 8:45 AM,  <sagar.a.kamble@...el.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Make drm_property_create_bitmask() a bit more generic by allowing the
> caller to specify which bits are in fact supported. This allows multiple
> callers to use the same enum list, but still create different versions
> of the same property with different list of supported bits.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Tested-by: Sagar Kamble <sagar.a.kamble@...el.com>

very minor nit here: this patch probably should fix up the callers of
this fxn for bisectability.  Although it could be the only other
caller was omapdrm which gets converted over to the new API a few
patches later..

with that,

Reviewed-by: Rob Clark <robdclark@...il.com>


> ---
>  drivers/gpu/drm/drm_crtc.c | 6 +++++-
>  include/drm/drm_crtc.h     | 3 ++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 3b7d32d..628d3d3 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2906,7 +2906,8 @@ EXPORT_SYMBOL(drm_property_create_enum);
>  struct drm_property *drm_property_create_bitmask(struct drm_device *dev,
>                                          int flags, const char *name,
>                                          const struct drm_prop_enum_list *props,
> -                                        int num_values)
> +                                        int num_values,
> +                                        unsigned int supported_bits)
>  {
>         struct drm_property *property;
>         int i, ret;
> @@ -2918,6 +2919,9 @@ struct drm_property *drm_property_create_bitmask(struct drm_device *dev,
>                 return NULL;
>
>         for (i = 0; i < num_values; i++) {
> +               if (!(supported_bits & (1 << i)))
> +                       continue;
> +
>                 ret = drm_property_add_enum(property, i,
>                                       props[i].type,
>                                       props[i].name);
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index d5c46c1..41b86d2 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -1070,7 +1070,8 @@ extern struct drm_property *drm_property_create_enum(struct drm_device *dev, int
>  struct drm_property *drm_property_create_bitmask(struct drm_device *dev,
>                                          int flags, const char *name,
>                                          const struct drm_prop_enum_list *props,
> -                                        int num_values);
> +                                        int num_values,
> +                                        unsigned int supported_bits);
>  struct drm_property *drm_property_create_range(struct drm_device *dev, int flags,
>                                          const char *name,
>                                          uint64_t min, uint64_t max);
> --
> 1.8.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/